Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Make item scroll tests more legible #554

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Make item scroll tests more legible #554

wants to merge 10 commits into from

Commits on Jan 12, 2019

  1. Make item scroll tests more legible 

    Also make them pass on my laptop.
    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    0c51e29 View commit details
    Browse the repository at this point in the history

  2. Use new version of scrollIntoView for clarity

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    5690755 View commit details
    Browse the repository at this point in the history

  3. Debug time

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    bad217c View commit details
    Browse the repository at this point in the history

  4. Oops

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    33c6628 View commit details
    Browse the repository at this point in the history

  5. Check the scroll width??

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    3620193 View commit details
    Browse the repository at this point in the history

  6. Check individual offsets

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    c6ddde8 View commit details
    Browse the repository at this point in the history

  7. Check clientWidth

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    33ab845 View commit details
    Browse the repository at this point in the history

  8. Check jasmine-content's width

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    06846a2 View commit details
    Browse the repository at this point in the history

  9. Well, that didn't help much

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    f3473f2 View commit details
    Browse the repository at this point in the history

  10. Find out what this value actually is on CI

    @50Wliu
    50Wliu committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    bd10c02 View commit details
    Browse the repository at this point in the history