Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glyphs for new data component types #104

Merged
merged 3 commits into from
May 8, 2024
Merged

Add glyphs for new data component types #104

merged 3 commits into from
May 8, 2024

Conversation

philipewingatlassian
Copy link
Contributor

Description

Adding the glyphs for the new component types

Checklist

Please ensure that each of these items has been addressed:

  • I have tested these changes in my local environment
  • I have added/modified tests as applicable to cover these changes
  • (Atlassian contributors only) I have removed any Atlassian-internal changes including internal modules, references to internal tickets, and internal wiki links

@philipewingatlassian philipewingatlassian requested a review from a team as a code owner May 8, 2024 21:23
@philipewingatlassian philipewingatlassian self-assigned this May 8, 2024
ihabib14
ihabib14 reviewed May 8, 2024
View reviewed changes
ui/src/components/assets/component-glyphs.tsx Outdated
},
{
id: 'DATA_PRODUCT',
label: 'Data product',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe Data Product instead of Data product?

@ihabib14 ihabib14 self-requested a review May 8, 2024 21:57
@philipewingatlassian philipewingatlassian merged commit 8ffce3d into main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihabib14 ihabib14 ihabib14 approved these changes

@eserranovalle eserranovalle eserranovalle approved these changes

@abocan-atl abocan-atl Awaiting requested review from abocan-atl

@PatrickAtlassian PatrickAtlassian Awaiting requested review from PatrickAtlassian

@subbuvenk-atlas subbuvenk-atlas Awaiting requested review from subbuvenk-atlas

@ebudtke-atl ebudtke-atl Awaiting requested review from ebudtke-atl

Assignees

@philipewingatlassian philipewingatlassian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipewingatlassian @eserranovalle @ihabib14