Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement] Reduce unnecessary REST calls #305

Open
annapieper opened this issue Aug 11, 2023 · 3 comments
Open

[improvement] Reduce unnecessary REST calls #305

annapieper opened this issue Aug 11, 2023 · 3 comments
Labels
enhancement New feature or request jira

Comments

@annapieper
Copy link

Even when the Slack panel is hidden and the issue view is opened by a user 2-3 REST calls are triggered which are not needed when Slack is not used in the project. For huge instances this triggers lots of trash requests and therefore unnecessary traffic:

  • <BASE_URL>/slack/issuepanel/data/<ISSUE_KEY>
  • <BASE_URL>/rest/slack/latest/connection-status/disconnected
  • <BASE_URL>/slack/configuration/status (only for admin users)

This calls should be suppressed.
@mvlasovatl mvlasovatl added the enhancement New feature or request label Aug 14, 2023
@annapieper
Copy link
Author

I'm currently implementing this issue.

annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Aug 30, 2023
@annapieper
Issue atlassian-labs#305: added check if slack panel is visible to pr…
0cd2a75 
…event unnecessary REST calls
annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Aug 30, 2023
@annapieper
Issue atlassian-labs#305: add check if slack panel is visible to prev…
384a2e7 
…ent unnecessary REST calls
annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Aug 30, 2023
@annapieper
Issue atlassian-labs#305: add check if slack panel is visible to prev…
511e769 
…ent unnecessary REST calls
@mvlasovatl mvlasovatl added the jira label Oct 4, 2023
@annapieper
Copy link
Author

Hello @mvlasovatl
Can you already tell if this issue will be considered to be included in the official app?

@mvlasovatl
Copy link
Collaborator

This change doesn't seem to break existing user experience and looks worthy including into the official version as performance improvement.
Unfortunately, the team within Atlassian doesn't have much time to process it, so external contributions are welcome!

annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Dec 11, 2023
@annapieper
Issue atlassian-labs#305: revert version changes for slack common mod…
fe8520d 
…ule; prevent ambiguities in JS
annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Dec 15, 2023
@annapieper
Issue atlassian-labs#305: revert version changes; add comments
0140ddd
annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Jan 22, 2024
@annapieper
Issue atlassian-labs#305: revert changes for preventing REST calls as…
6183806 
… they may have unindented impact on other functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvlasovatl @annapieper