Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out when no key in JGET #9

Open
aartaka opened this issue Oct 6, 2023 · 0 comments
Open

Error out when no key in JGET #9

aartaka opened this issue Oct 6, 2023 · 0 comments
Labels
backwards-incompatible Backwards-incompatible changes for next major release. bug Something isn't working

Comments

@aartaka
Copy link
Contributor

aartaka commented Oct 6, 2023

Right now no-key error only happens in jget*, but it's intended to happen in the regular jget starting from the next major release. The benefit is: malformed JSON is easier to spot and fix, while jbind patterns are behaving in a more correct way in regards to validation.

Yes, panicking more often might be annoying, but this library is intended to be interactive, so it's better to error than not—to be honest to the user.
@aartaka aartaka added bug Something isn't working backwards-incompatible Backwards-incompatible changes for next major release. labels Oct 6, 2023
@aartaka aartaka changed the title Error out when no key in jget Error out when no key in JGET Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards-incompatible Backwards-incompatible changes for next major release. bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aartaka