-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change defaults and accept per-package options. #3
Comments
Per-package thing feels somewhat novel and unintuitive. Most use-cases are either per-application or local changes.
So I'm not sure we should add this level of complexity, if there are quite conventional ways to manage options. |
That's the point: we're dealing with top-level stuff here (package definitions), and we would like to not go full global. So neither globals setting nor So what does it mean to be local in this case? It means applying settings only for the target package. It's admittedly not very conventional, but in makes sense in my opinion. |
Yes, that is fair, things are not exactly clear in the macro-sugared-CLOS-magic lands (¬‿¬) Okay, let it be per-package settings. But no subpackages!—there's no universal naming scheme for subpackages, and trying to guess one could be quite unintuitive. Imaginve if someone with the package naming convention like |
Hmmmmm, given that logic, I should probably remove the subpackage-related code from A new release time, I guess... |
Then nothing would happen. I think it's fine. |
But still, the logic does not do what it claims in the situations where one'd expect it to, so maybe it's not worth including it... |
A docstring explaining what a subpackage is should be enough. |
Still uneasy about this, but okay |ω・) |
I'll leave this issue open then, only changing the default accessor transformer for now. |
In anticipation of nsymbols refactoring, inspired by atlas-engineer/nclasses#3 (comment)
I'd like to change the default accessor-name transformer to be the slot-name itself (
(nclasses:make-name-transformer name)
).I'd also like to enable packages to set their defaults. Something along these lines:
@aartaka You once suggested that this
set-option
would be overkill and the user is better off writing their own wrapping macros.Pros and cons?
The text was updated successfully, but these errors were encountered: