Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Node not using ActionDeviceKey ActionGroupKey ActionGroupMask values #104

Open
dagata-mining opened this issue Sep 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@dagata-mining
Copy link

dagata-mining commented Sep 14, 2022

The trigger node example is not using the launch file parsed data
https://github.com/astuff/avt_vimba_camera/blob/ros1_master/src/trigger.cpp#L73

bool Trigger::PrepareActionCommand()
{
  return (SetIntFeatureValue("ActionDeviceKey", 1) && SetIntFeatureValue("ActionGroupKey", 1) &&
          SetIntFeatureValue("ActionGroupMask", 1));
}

Should use the object property instead of one
int action_device_key_;
int action_group_key_;
int action_group_mask_;

bool Trigger::PrepareActionCommand()
{
  return (SetIntFeatureValue("ActionDeviceKey", action_device_key_) && SetIntFeatureValue("ActionGroupKey", action_group_key_) &&
          SetIntFeatureValue("ActionGroupMask", action_group_mask_));
}
@icolwell-as
Copy link
Member

Good catch! feel free to open a PR to fix it.

@icolwell-as icolwell-as added the bug Something isn't working label Oct 6, 2022
dagata-mining pushed a commit to dagata-mining/avt_vimba_camera that referenced this issue Oct 8, 2022
icolwell-as pushed a commit that referenced this issue Oct 11, 2022
…repareActionCommand (#108)

Co-authored-by: Dagata_Mining <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants