Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for temporary table upload in alma #3118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andamian
Copy link

@andamian andamian commented Oct 11, 2024

Solution for #3030

Also cleaned up some of the alma remote tests to make them a little bit faster.

@pep8speaks
Copy link

pep8speaks commented Oct 11, 2024

Hello @andamian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-12 00:06:29 UTC

@andamian andamian marked this pull request as draft October 11, 2024 17:48
Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice addition, just needs a little clearer documentation - can you provide an example upload table in the narrative docs?

astroquery/alma/core.py Outdated Show resolved Hide resolved
astroquery/alma/core.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (92adbe8) to head (f41f708).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3118      +/-   ##
==========================================
- Coverage   67.39%   67.37%   -0.02%     
==========================================
  Files         233      233              
  Lines       18421    18410      -11     
==========================================
- Hits        12415    12404      -11     
  Misses       6006     6006              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz added the alma label Oct 11, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Oct 11, 2024
@andamian andamian marked this pull request as ready for review October 11, 2024 19:10
@andamian
Copy link
Author

Not sure what the problem is now. There's 100% patch coverage.

@bsipocz
Copy link
Member

bsipocz commented Oct 11, 2024

Not sure what the problem is now. There's 100% patch coverage.

Ignore that, coverage number doesn't take remote tests into account.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I'll leave the actual approval and merge to Adam though.

One minor comment, that I see a bunch of test failures in the docs, all of those are present on main, too but it would be nice to eventually clean them up.

astroquery/alma/core.py Outdated Show resolved Hide resolved
@andamian andamian force-pushed the CADC-13741 branch 3 times, most recently from 0970283 to d6363c6 Compare October 11, 2024 23:47
Co-authored-by: Adam Ginsburg <[email protected]>

Co-authored-by: Adam Ginsburg <[email protected]>
@andamian andamian changed the title Added support for temporary table upload Added support for temporary table upload in alma Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants