Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Expand CDMS testing #3095

Open
2 tasks
keflavich opened this issue Sep 19, 2024 · 3 comments
Open
2 tasks

ENH: Expand CDMS testing #3095

keflavich opened this issue Sep 19, 2024 · 3 comments

Comments

@keflavich
Copy link
Contributor

Following #3094, it is clear that there is a range of untested parameters in the CDMS module that require tests.

TODO includes:

  • Regression test for 3094 (check that 100501 can be parsed)
  • Systematic check that all molecules can be queried
@keflavich
Copy link
Contributor Author

The systematic search will begin with something like:

from astroquery.linelists.cdms import CDMS
from astropy import units as u

sptbl = CDMS.get_species_table()

for row in sptbl:
    result = CDMS.query_lines(1*u.GHz, 1*u.THz, molecule=str(row['tag']), parse_name_locally=False)
    print(tag, row['molecule'], len(result))

but either CDMS is down right now or they're blocking the airport IP.

@kmaitreys
Copy link

kmaitreys commented Sep 19, 2024

Yeah, I tried something like this but some of my requests got timed out as well. Although I still managed to fetch transitions for most of molecules in the database. While doing that, I encountered one more bug

ValueError: invalid literal for int() with base 10: '1 1 2' for molecule 028528 

Here 028528 is another molecule which has some formatting bug. I will add a fix for this as well soon on my #3094 PR.

EDIT: I am not sure that only these two TAG values were problematic though, so a more exhaustive check will be nice.

@bsipocz
Copy link
Member

bsipocz commented Sep 19, 2024

Yeap, adding just those one or two to #3094 would be enough, and this issue can be addressed in a follow-up PR that does a the exhaustive checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants