Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test RC provider packages for https://github.com/apache/airflow/issues/32460 #1234

Closed
wants to merge 3 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@pankajkoti
Copy link
Collaborator

@Lee-W is this action also supposed to deploy to astro cloud? I am not sure if it happened or not? Could you please check?

@Lee-W
Copy link
Contributor

Lee-W commented Jul 10, 2023

Yes, let me check

@pankajkoti
Copy link
Collaborator

@Lee-W
Copy link
Contributor

Lee-W commented Jul 10, 2023

Yes, I just checked it's this one and seem to work fine

@pankajkoti
Copy link
Collaborator

@Lee-W Thank you for checking. We can perhaps give our +1 (non-binding) for the RC4 out now then

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ec3bd97) 98.58% compared to head (8b0367d) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          90       90           
  Lines        5389     5389           
=======================================
  Hits         5313     5313           
  Misses         76       76           
Impacted Files Coverage Δ
astronomer/providers/amazon/aws/operators/emr.py 100.00% <100.00%> (ø)
astronomer/providers/amazon/aws/sensors/emr.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, mypy check successful and we can close this PR now.

@Lee-W Lee-W closed this Jul 10, 2023
@Lee-W
Copy link
Contributor

Lee-W commented Jul 10, 2023

Sounds good :)

@github-actions github-actions bot deleted the rc-test-2023-07-10T00-26-06UTC branch July 10, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants