-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organization documentation #45
base: main
Are you sure you want to change the base?
Conversation
Run report for d47d8e42Total time: 40.2s | Comparison time: 36.9s | Estimated loss: 3.3s (8.2% slower)
Touched files
|
This page has a broken link to the Why Astro page underneath the Important header https://7de22891.astrolicious.pages.dev/docs/ A minor thing and probably more of a nitpick than constructive feedback, the cards in the "friends" section on the home page are different heights and widths, making them the same would look better IMO. |
@gingerchew not at all. I like to get feedback and your point makes a lot of sense. I like your mockup too. Do you have an idea how to implement it in the code? |
@alexanderniebuhr Yeah! I can code up a PR later tonight or give the gist of the set up. |
@@ -0,0 +1,6 @@ | |||
{ | |||
"name": "Inox Tools", | |||
"logo": "https://inox-tools.fryuni.dev/_astro/shield.FOC531WK_Z23FUGT.webp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What goes into this hash? I haven't really looked into this part of the source code, but if something besides the original image is used to compute the hash it could change kinda at random. I think I should expose that as a stable URL 🤔.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a stable URL for the image, doesn't have to come from the site, can also be a GitHub raw url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image on GH is a non-optimized PNG: https://github.com/Fryuni/inox-tools/blob/main/assets/shield.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that could be fine for this, we could even add astro:assets
for remote images here 🤔
Co-authored-by: Luiz Ferraz <[email protected]>
7e87dd6
to
03aa80c
Compare
No description provided.