Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organization documentation #45

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

alexanderniebuhr
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 9, 2024

Run report for d47d8e42

Total time: 40.2s | Comparison time: 36.9s | Estimated loss: 3.3s (8.2% slower)

Action Time Status Info
🟩 SyncWorkspace 4.8ms Passed
⬛️ SetupToolchain(node:20.16.0) 1.3s Skipped
🟩 SyncProject(node, site) 0.3ms Passed
🟩 InstallWorkspaceDeps(node:20.16.0) 12s Passed
🟩 RunTask(site:imports) 290.1ms Passed
🟩 RunTask(site:format) 294.7ms Passed
🟩 RunTask(site:lint) 301.6ms Passed
🟩 RunTask(site:sync) 3.2s Passed
🟩 RunTask(site:check) 8.6s Passed
🟩 RunTask(site:build) 15.1s Passed
Touched files
.github/workflows/deployment.yml
.moon/toolchain.yml
.node-version
.prototools
.vscode/settings.json
apps/site/astro.config.ts
apps/site/db/config.ts
apps/site/moon.yml
apps/site/package.json
apps/site/public/favicon.png
apps/site/public/hero.png
apps/site/src/components/FriendsCard.astro
apps/site/src/content/config.ts
apps/site/src/content/docs/docs/brand.mdx
apps/site/src/content/docs/docs/governance.mdx
apps/site/src/content/docs/docs/guidebook/community-content.mdx
apps/site/src/content/docs/docs/guidebook/cross-posting.mdx
apps/site/src/content/docs/docs/guidebook/recipes.mdx
apps/site/src/content/docs/docs/guidebook/tips.mdx
apps/site/src/content/docs/docs/index.mdx
apps/site/src/content/docs/docs/me.mdx
apps/site/src/content/docs/docs/test.mdx
apps/site/src/content/docs/docs/workflows/maintainers.mdx
apps/site/src/content/docs/docs/workflows/onboarding.mdx
apps/site/src/content/docs/docs/workflows/reviewing.mdx
apps/site/src/content/docs/docs/workflows/rfc.mdx
apps/site/src/content/docs/docs/workflows/setup.mdx
apps/site/src/content/docs/docs/workflows/submit.mdx
apps/site/src/content/docs/docs/workflows/triaging.mdx
apps/site/src/content/friends/aik.json
apps/site/src/content/friends/inox.json
apps/site/src/env.d.ts
apps/site/src/pages/index.astro
apps/site/src/pages/submit/index.astro
apps/site/src/pages/submit/success.astro
biome.json
package.json
pnpm-lock.yaml

@github-actions github-actions bot requested a deployment to [site] (add-documentation) August 4, 2024 06:11 Abandoned
@github-actions github-actions bot requested a deployment to [site] (add-documentation) August 4, 2024 06:32 Abandoned
@github-actions github-actions bot requested a deployment to [site] (add-documentation) August 4, 2024 06:39 Abandoned
@github-actions github-actions bot requested a deployment to [site] (add-documentation) August 4, 2024 06:43 Abandoned
@github-actions github-actions bot requested a deployment to [site] (add-documentation) August 4, 2024 06:54 Abandoned
@github-actions github-actions bot requested a deployment to [site] (add-documentation) August 4, 2024 06:55 Abandoned
@gingerchew
Copy link

This page has a broken link to the Why Astro page underneath the Important header https://7de22891.astrolicious.pages.dev/docs/

A minor thing and probably more of a nitpick than constructive feedback, the cards in the "friends" section on the home page are different heights and widths, making them the same would look better IMO.

I mocked an idea up

@alexanderniebuhr
Copy link
Member Author

A minor thing and probably more of a nitpick than constructive feedback, the cards in the "friends" section on the home page are different heights and widths, making them the same would look better IMO.

@gingerchew not at all. I like to get feedback and your point makes a lot of sense. I like your mockup too. Do you have an idea how to implement it in the code?

@gingerchew
Copy link

@alexanderniebuhr Yeah! I can code up a PR later tonight or give the gist of the set up.

gingerchew added a commit to gingerchew/dotdev that referenced this pull request Aug 5, 2024
apps/site/src/components/FriendsCard.astro Outdated Show resolved Hide resolved
apps/site/src/components/FriendsCard.astro Outdated Show resolved Hide resolved
apps/site/src/content/docs/docs/brand.mdx Outdated Show resolved Hide resolved
@@ -0,0 +1,6 @@
{
"name": "Inox Tools",
"logo": "https://inox-tools.fryuni.dev/_astro/shield.FOC531WK_Z23FUGT.webp",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What goes into this hash? I haven't really looked into this part of the source code, but if something besides the original image is used to compute the hash it could change kinda at random. I think I should expose that as a stable URL 🤔.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a stable URL for the image, doesn't have to come from the site, can also be a GitHub raw url?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that could be fine for this, we could even add astro:assets for remote images here 🤔

apps/site/src/pages/index.astro Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants