-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cnp.import_array
for numpy>=2
#75
Conversation
Perhaps the CI could be made to run with numpy>=2? That way it would be clearer that it works. |
Good idea, will do now |
@mdavezac done. Not sure if the tests here are exhaustive enough to know that this will fix downstream, though. |
Are we sure we want to force numpy>=2? This could have downstream implications? @CosmoMatt what are you thoughts? We might want to pause merging this until we've had a chance to also update other codes. |
@jasonmcewen currently |
Thanks @paddyroddy . Yes, we may need to pin to numpy 1 in the interium. We should support numpy 2 in the near future but we don't want to break a large number of our codes that use ssht before they've also been updated to support numpy 2. |
This is just in the ci, it doesn't affect users. Admittedly, it does depend on the test coverage... Though, if it used to fail at the import stage, then at least this change to the coffee and to the ci cover that. |
@mdavezac so is this safe to be merged? I don't have the power anyway |
@mdavezac will there be a new python release/pre-release? |
Hopefully fixes #74, see https://cython.readthedocs.io/en/stable/src/tutorial/numpy.html#adding-types