Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An invalid netrc file does not produce a warning #7685

Open
mathialo opened this issue Sep 25, 2024 · 1 comment
Open

An invalid netrc file does not produce a warning #7685

mathialo opened this issue Sep 25, 2024 · 1 comment
Labels
error messages Messaging when something goes wrong help wanted Contribution especially encouraged tracing Verbose output and debugging

Comments

@mathialo
Copy link

I recently migrated one of our projects from poetry to uv, and one thing that made me stumble was a syntax error in my netrc file. Uv would just silently ignore the error and move on as if the netrc file did not exist, which made it a bit hard to figure out what was going on.

I think a better approach would be if the Netrc::new() call returns a parsing error, to log a warning about it before ignoring it, to let users know why the netrc file is being ignored.

@zanieb zanieb added error messages Messaging when something goes wrong tracing Verbose output and debugging labels Sep 25, 2024
@zanieb
Copy link
Member

zanieb commented Sep 25, 2024

Seems reasonable, but we'd want to be careful to only display this once and only if we needed credentials.

@zanieb zanieb added the help wanted Contribution especially encouraged label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Messaging when something goes wrong help wanted Contribution especially encouraged tracing Verbose output and debugging
Projects
None yet
Development

No branches or pull requests

2 participants