range: make 'as_singleton' return a borrow #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's cheaper this way if the caller only needs a `&V`. If the caller needs a `V`, then they can clone it. We can also move it to an impl block that only requires `Ord`, so that it will work with `V` types that don't implement `Clone`.
konstin
approved these changes
Feb 8, 2024
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 14, 2024
This brings in a [PR] that makes `Range::as_singleton` return a borrow. [PR]: astral-sh/pubgrub#23
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 14, 2024
This brings in a [PR] that makes `Range::as_singleton` return a borrow. [PR]: astral-sh/pubgrub#23
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 15, 2024
This brings in a [PR] that makes `Range::as_singleton` return a borrow. [PR]: astral-sh/pubgrub#23
BurntSushi
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 15, 2024
This brings in a [PR] that makes `Range::as_singleton` return a borrow. [PR]: astral-sh/pubgrub#23
konstin
pushed a commit
that referenced
this pull request
Mar 6, 2024
It's cheaper this way if the caller only needs a `&V`. If the caller needs a `V`, then they can clone it. We can also move it to an impl block that only requires `Ord`, so that it will work with `V` types that don't implement `Clone`.
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
It's cheaper this way if the caller only needs a `&V`. If the caller needs a `V`, then they can clone it. We can also move it to an impl block that only requires `Ord`, so that it will work with `V` types that don't implement `Clone`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's cheaper this way if the caller only needs a
&V. If the callerneeds a
V, then they can clone it.We can also move it to an impl block that only requires
Ord, so thatit will work with
Vtypes that don't implementClone.