Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devdocs buffers to be bookmarked #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aepyornis
Copy link

@aepyornis aepyornis commented Apr 4, 2024

This does what is asked by #32. Using bookmark-set from the devdocs buffer will store that current page.

@astoff
Copy link
Owner

astoff commented Apr 4, 2024

This looks great! Since devdocs.el is on ELPA, you'd need the FSF copyright assignment — do you have it?

@aepyornis
Copy link
Author

ah nope, but send me the instructions I can do that.

@astoff
Copy link
Owner

astoff commented Apr 4, 2024

@aepyornis Here are some instructions: https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future And here is an explanation of why the FSF asks for this: https://www.gnu.org/licenses/why-assign.html

You can also ask on the Emacs mailing list [email protected] for more information. I hope it works out for you :-).

@aepyornis
Copy link
Author

Thanks! Oh wow, didn't realize the paperwork involved :) Hopefully I'll get it sorted soon...

@jdtsmith
Copy link

Any progress here? Would be great to have devdocs bookmark able (e.g. for use with activities).

@aepyornis
Copy link
Author

aepyornis commented Jun 20, 2024

Ah sorry, my employer hasn't signed the proper disclosure form, so I haven't recieved FSF copyright assignment. but if it were up to me, I consider this code to be in the public domain so we can start bookmarking devdocs :)

@astoff
Copy link
Owner

astoff commented Jun 24, 2024

I feel we wouldn't be violating the spirit of the idea that tiny changes don't need copyright assignment, but the criterium is that those should be under 15 lines of code. If you remove commentary and linter-appeasement and spacious formatting I think the PR would fit in that quota.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants