Support parsing srt without sequence numbers. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many srt in the wild that are missing sequence numbers. It's easy to detect by looking for an empty line vs index/sequence in the line before the time. In my analysis of many srt I have not seen ones missing the empty line, but it's feasible that these also exist. This shouldn't affect parsing otherwise, however, and in my experience the missing sequence number is common enough that it's useful to handle.
|
Examples of these srt files: https://media.defcon.org/DEF%20CON%2023/DEF%20CON%2023%20video/ |
asticode
reviewed
Oct 1, 2023
|
Thanks for the PR! ❤️ |
|
Let me know whether you need a tag 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many srt in the wild that are missing sequence numbers. It's easy to detect by looking for an empty line vs index/sequence in the line before the time. In my analysis of a good number of srt I have not seen ones missing the empty line, but it's feasible that these also exist. This shouldn't affect parsing otherwise, however, and in my experience the missing sequence number is common enough that it's useful to handle.