fix: Add support for X-TIMESTAMP-MAP r/w persistence #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR ! ❤️ Let me know whether you need a tag 👍 |
Hey yes, a new tag would be great thank you! |
|
FYI I've created a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in this issue here, I'd like to be able to specify an
X-TIMESTAMP-MAPbased on some external factors in my application which uses astisub. However, as part of this, I think that the WebVTT reader automatically applying the time offset defined therein will cause duplicate applications of the time offset in the case where a WebVTT with anX-TIMESTAMP-MAPis read, manipulated, then also written back out.So this PR adds a struct for storing the parsed
X-TIMESTAMP-MAPdata on theSubtitles' Metadata field, that way it can be manually applied to the subtitles if necessary, or left as is and written back to WebVTT files so that some upstream client can apply the time correction. Likewise, this also allows manually configuring aX-TIMESTAMP-MAPto be written to a WebVTT file when it previously did not exist there, the use-case I originally needed to solve for.