Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GuiActionRunner #242

Open
lbalazscs opened this issue Nov 20, 2019 · 0 comments
Open

Improve GuiActionRunner #242

lbalazscs opened this issue Nov 20, 2019 · 0 comments

Comments

@lbalazscs
Copy link
Contributor

At the end of GuiActionRunner there is the following code:

    if (caughtException instanceof RuntimeException) {
      appendStackTraceInCurrentThreadToThrowable(caughtException, "execute");
      throw (RuntimeException) caughtException;
    }
    if (caughtException instanceof Error) {
      caughtException.fillInStackTrace();
      throw (Error) caughtException;
    }

I think it is not reasonable to fill in the stack trace for the Errors, throwing away the original stack trace: Errors should be treated the same as RuntimeExceptions. Or - if there is some reason for doing so - then at least don't throw away the stack trace of AssertionErrors, they are normal and expected during testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant