Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation warnings from generated assertions #143

Open
ebramirez opened this issue Jun 11, 2020 · 5 comments
Open

Remove deprecation warnings from generated assertions #143

ebramirez opened this issue Jun 11, 2020 · 5 comments

Comments

@ebramirez
Copy link
Contributor

The assertions generated uses org.assertj.core.util.Objects.areEqual and org.assertj.core.util.Objects.areEqualArrays which are deprecated and show in the applications warning logs.

Should use the suggested methods instead.
@joel-costigliola
Copy link
Member

Fair point, keen to contribute it @ebramirez?

@ebramirez
Copy link
Contributor Author

Sure!

Here you have it: #144

@joel-costigliola By the way, to run the tests I had to add the javax.annotation-api test dependency. I have not pushed that change as part of the PR just in case this was intentional. Is this a known thing?

@joel-costigliola
Copy link
Member

This project was developed with the JDK 8 which provides it but I guess you are using JDK 11 (or even 14!)

@ebramirez
Copy link
Contributor Author

You absolutely right, I completely forgot about that change.

@rob-valor
Copy link

Just wondering, is there a specific reason why this change can't be release yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joel-costigliola @ebramirez @rob-valor