Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check modules that are enabled with cmake #21

Open
David-Estevez opened this issue Feb 9, 2015 · 6 comments
Open

Check modules that are enabled with cmake #21

David-Estevez opened this issue Feb 9, 2015 · 6 comments
Assignees

Comments

@David-Estevez
Copy link
Collaborator

Some modules cannot be disabled in cmake, as they are dependencies to other modules.

We should check these variables and enable only logic combinations (e.g. disabling tests, disabling main program, differenciating between tests and mockup tests, etc).

@PeterBowman
Copy link
Member

@David-Estevez these combinations (I guess you refer to cmake_dependent_option() commands and of the like) are not implemented, I wonder if they ever were. Could you please expand on your initial thoughts? Are those concerns still valid today?

See also #95.

@David-Estevez
Copy link
Collaborator Author

In some old version of Robot Devastation, we had all different modules listed as ENABLE_X options, which didn't make sense because most of those modules were related and depended on each other, and that was the reason of this issue.

The solution I had in mind was to allow disabling blocks of modules (i.e. allowing the user to disable the compilation of the RdServer if you only wanted to compile the main game.

My old self didn't know about that option, so the implementation I I was thinking then was to use simple if() cmake commands.

@PeterBowman
Copy link
Member

Thanks for the clarification, @David-Estevez. I rewinded the repo to early 2015 and couldn't find those ENABLEs, so I concluded that such modularization never took place.

We'l have to play with the currently available options:

  • ENABLE_robotDevastation
  • ENABLE_rdServer
  • ENABLE_tests

I'm going to mark this issue as blocked (superseded?) by #95 since any planned/ongoing work would probably clash with the modifications introduced here.

@PeterBowman PeterBowman self-assigned this Mar 23, 2017
@PeterBowman
Copy link
Member

Note to self: use cmake_dependent_option() to handle dependencies? (i.e. don't compile tests alone, force to build together with RD libraries)

@PeterBowman
Copy link
Member

I'd like to apply roboticslab-uc3m/questions-and-answers#54 here, but we should first decide on the approach for modularization and mandatory/optional components, i.e. it wouldn't make sense to require SDL if I just want to compile the server app.

@PeterBowman
Copy link
Member

I'd like to apply roboticslab-uc3m/questions-and-answers#54 here, but we should first decide on the approach for modularization and mandatory/optional components, i.e. it wouldn't make sense to require SDL if I just want to compile the server app.

Done at 45d01fa just to keep things tidy. We don't know yet how to proceed with the issue described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants