refactor: py_venv macro improved defaults for usability #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After testing real developer workflows in vscode, this way works correctly and is much more practical. Fixes #395
alexeagle
force-pushed
the
venv_location
branch
from
737b2d2
to
e6c1c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing real developer workflows in vscode, this way works correctly and is much more practical.
Fixes #395
Changes are visible to end-users: no
Test plan
Try a few things in VScode:
bazel run app:app_bin.venvand see VSCode offers to open the resulting virtual env, labels it wellbazel run app_bin.venvwhich also is detectedbazel run app_test.venvand the editor offers to switchpython -m pytestand the tests run correctly, meaning they should also be debuggable