Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow symlink collision error to be downgraded #369

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

mattem
Copy link
Member

@mattem mattem commented Jul 17, 2024

Introduces an attr allowing the symlink collision errors to be downgraded to a warning or ignored.

Closes #358


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): yes
  • Suggested release notes appear below:

Allow the "conflicting symlinks" error when creating a venv to be downgraded to a warning and ignored.

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Run //py/tests/virtual/django:manage with the pyqt6 packages installed.

py/private/py_binary.bzl Outdated Show resolved Hide resolved
py/private/py_binary.bzl Show resolved Hide resolved
py/tools/py/src/pth.rs Show resolved Hide resolved
py/private/py_binary.bzl Outdated Show resolved Hide resolved
py/private/py_binary.bzl Outdated Show resolved Hide resolved
py/private/py_binary.bzl Show resolved Hide resolved
py/tools/py/src/pth.rs Show resolved Hide resolved
py/tools/py/Cargo.toml Outdated Show resolved Hide resolved
py/tools/py/src/pth.rs Outdated Show resolved Hide resolved
py/private/py_binary.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle merged commit de35052 into main Jul 19, 2024
14 checks passed
@alexeagle alexeagle deleted the symlink_clash branch July 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Conflicting symlinks found when attempting to create venv.
3 participants