Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure coverage providers are output from both py_library and py_binary rules #168

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: ensure coverage providers are output from both py_library and py_binary rules #168

merged 1 commit into from
Jul 31, 2023

Conversation

mattem
Copy link
Member

@mattem mattem commented Jul 31, 2023 •
edited
Loading

Ensure py_library and py_binary create coverage info providers.

Type of change

  • Bug fix (change which fixes an issue)

For changes visible to end-users

  • Relevant documentation has been updated
  • Suggested release notes are provided below:

The py_library and py_binary rules now create the InstrumentedFilesInfo provider for coverage.

Test plan

  • Manual testing

@mattem mattem marked this pull request as ready for review July 31, 2023 21:19
@mattem mattem requested a review from alexeagle July 31, 2023 21:19
@mattem mattem merged commit 1fb1612 into main Jul 31, 2023
1 check passed
@mattem mattem deleted the coverage branch July 31, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattem @alexeagle