Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing deps in py_pytest_main #163

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jun 22, 2023

Type of change

  • New feature or functionality (change which adds functionality)

py_pytest_main generates a py_library that depends on pytest without declaring it as the dependency. This PR adds a deps attribute to py_pytest_main, and pass it down to the py_library, because:

  1. it's more "correct" to have a py_library declaring its own dependency instead of having its consumer to do that job
  2. Gazelle would remove @pypi_pytest//:pkg from the py_test target that depends on py_pytest_main, because the py_test target doesn't import pytest.

Test plan

  • Covered by existing test cases

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mattem mattem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattem mattem enabled auto-merge (squash) July 31, 2023 21:21
@mattem mattem merged commit 88ebe87 into aspect-build:main Jul 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants