Added Russian language #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected swagger API url Updated readme.md
Tpt
reviewed
Jan 19, 2017
| @@ -60,7 +60,7 @@ def _v1_spec(): | |||
| 'url': 'http://www.apache.org/licenses/LICENSE-2.0.html' | |||
| } | |||
| }, | |||
| 'host': 'syntaxnet.askplatyp.us', | |||
| 'host': '127.0.0.1:7000', | |||
There was a problem hiding this comment.
We should find a way to get the current URL. Here it'll break the "production" version of this service at http://syntaxnet.askplatyp.us
Should probably be done in an other pull request
There was a problem hiding this comment.
yesterday this doesnt work for me
|
You probably want to add "Russian" to install-syntaxnet-debian.sh and maybe also to the Swagger UI defined in flask_server.py |
|
I read in [1] that Russian does not have text segmentation yet. I'm afraid it's a blocker (except if the documentation is outdated). [1] https://github.com/tensorflow/models/blob/master/syntaxnet/universal.md |
|
Sadly no tokenizer for Russian :-(. So, this PR won't work as it is. We have to find/train a tokenizer. |
|
No problem .) |
ghost
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected swagger API url
Updated readme.md