From 685b2eb70d45643129ae8038788667a7e9a77748 Mon Sep 17 00:00:00 2001 From: Ashish Singh Date: Wed, 7 Aug 2024 02:49:58 +0530 Subject: [PATCH] Increase worker count in line with snapshot deletion threadpool count Signed-off-by: Ashish Singh --- .../repositories/blobstore/BlobStoreRepository.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java b/server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java index 01d79e08259fc..ad6bc9ffa9725 100644 --- a/server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java +++ b/server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java @@ -1204,7 +1204,7 @@ private void asyncCleanupUnlinkedShardLevelBlobs( ); // Start as many workers as fit into the snapshot pool at once at the most - final int workers = Math.min(threadPool.info(ThreadPool.Names.SNAPSHOT).getMax(), staleFilesToDeleteInBatch.size()); + final int workers = Math.min(threadPool.info(ThreadPool.Names.SNAPSHOT_DELETION).getMax(), staleFilesToDeleteInBatch.size()); for (int i = 0; i < workers; ++i) { executeStaleShardDelete(staleFilesToDeleteInBatch, remoteStoreLockManagerFactory, groupedListener); } @@ -1740,7 +1740,7 @@ private void cleanupStaleIndices( // Start as many workers as fit into the snapshot pool at once at the most final int workers = Math.min( - threadPool.info(ThreadPool.Names.SNAPSHOT).getMax(), + threadPool.info(ThreadPool.Names.SNAPSHOT_DELETION).getMax(), foundIndices.size() - survivingIndexIds.size() ); for (int i = 0; i < workers; ++i) { @@ -1979,6 +1979,7 @@ private void cleanupOldShardGens(RepositoryData existingRepositoryData, Reposito ) ); try { + logger.info("{} shards generations to be deleted as part of cleanupOldShardGens", toDelete); deleteFromContainer(rootBlobContainer(), toDelete); } catch (Exception e) { logger.warn("Failed to clean up old shard generation blobs", e);