Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change asdf-pandoc to be maintained by StephanMeijer and Fbrisset #183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StephanMeijer
Copy link

@StephanMeijer StephanMeijer commented May 28, 2024

asdf-pandoc does not seem to have been claimed as community repository. I would like to do so so that I can work on my changes as a community effort.

@Fbrisset is the current maintainer of the repository present in the Index.

asdf-pandoc does not seem to have been claimed as community repository. I would like to do so so that I can work on my changes as a community effort.
@StephanMeijer StephanMeijer requested a review from a team as a code owner May 28, 2024 17:04
@StephanMeijer StephanMeijer changed the title Change asdf-pandoc to be maintained by StephanMeijer Change asdf-pandoc to be maintained by StephanMeijer and Fbrisset May 28, 2024
@smorimoto
Copy link
Member

CC: @sys9kdr

@sys9kdr
Copy link
Contributor

sys9kdr commented May 29, 2024

ya, I know Feberist/asdf-pandoc is in index. But Feberist/asdf-pandoc isn't good, IMHO. It doesn't meet basic requirements, and we can only download a few versions of Pandoc with this plugin. see asdf-vm/asdf-plugins#995

I am against putting the current Feberist/asdf-pandoc that doesn't implement basic features into the Community.

If sys9kdr/asdf-pandoc is added to the official index, I will add it to the community. see asdf-vm/asdf-plugins#996

@StephanMeijer
Copy link
Author

StephanMeijer commented May 29, 2024

and we can only download a few versions of Pandoc with this plugin

Correct. I put out a pull request for that.

I am against putting the current Feberist/asdf-pandoc that doesn't implement basic features into the Community.

I'm proposing to put my fork out. I can see those issues being quickly resolved.

If sys9kdr/asdf-pandoc is added to the official index, I will add it to the community.

I'm not against that. Either is fine for me to be honest. But something does need to happen because Feberist/asdf-pandoc doesn't support Haskell PVP and assumes semver which causes the issue you referenced.

@StephanMeijer
Copy link
Author

See also: Fbrisset/asdf-pandoc#6 jgm/pandoc#9810

@Fbrisset
Copy link

Hi ! I merged the fix proposed by @StephanMeijer. If there are other requirements for the tool to be integrated into ASDF-Community. Do not hesitate to tell me.

@sys9kdr
Copy link
Contributor

sys9kdr commented May 30, 2024

I saw @StephanMeijer's PR, but there are still some issues Fbrisset/asdf-pandoc#6 . I'll create issues and send a PRs to @Fbrisset later.

@StephanMeijer
Copy link
Author

@sys9kdr @Fbrisset What do you think going forward making contributions as a team of three? effectively merging all our efforts?

@Fbrisset
Copy link

I think it's a good idea. We can only get better by being together.

@sys9kdr
Copy link
Contributor

sys9kdr commented Jun 3, 2024

@StephanMeijer @Fbrisset okay. I'll close my PRs in asdf-vm.

@sys9kdr
Copy link
Contributor

sys9kdr commented Jun 3, 2024

@smorimoto I confirmed that the quality was good enough. Please merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants