Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI builds #599

Open
WhiteBlackGoose opened this issue Oct 7, 2022 · 2 comments
Open

Fix CI builds #599

WhiteBlackGoose opened this issue Oct 7, 2022 · 2 comments
Assignees
@gauravagrwal
Labels
<easy> up-for-grabs An easy task, a good issue to close if you're new to the project. hacktoberfest Close these to participate in Hacktoberfest! Minor bug Minor bugs that don't affect the overall computations up-for-grabs Issues which don't require internal knowledge to close so can be completed by outside contributors

Comments

@WhiteBlackGoose
Copy link
Member

Currently in master C# tests and build fail for package AngouriMath.Experimental for macOS. Since generic math is not implemented, we need to make AngouriMath.Experimental target .NET 7, add installing the corresponding runtime in yml files, and make it work:

  • Change AngouriMath.Experimental's target to .NET 7
  • Fix CSharpBuild.yml and CSharpTest.yml by adding .NET 7
  • Fix CI (it will run on opened draft PR)
@WhiteBlackGoose WhiteBlackGoose added Minor bug Minor bugs that don't affect the overall computations up-for-grabs Issues which don't require internal knowledge to close so can be completed by outside contributors <easy> up-for-grabs An easy task, a good issue to close if you're new to the project. hacktoberfest Close these to participate in Hacktoberfest! labels Oct 7, 2022
@gauravagrwal
Copy link

Hi @WhiteBlackGoose, Can I work on this ?

@WhiteBlackGoose
Copy link
Member Author

Hi, assigned you. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravagrwal gauravagrwal

Labels
<easy> up-for-grabs An easy task, a good issue to close if you're new to the project. hacktoberfest Close these to participate in Hacktoberfest! Minor bug Minor bugs that don't affect the overall computations up-for-grabs Issues which don't require internal knowledge to close so can be completed by outside contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WhiteBlackGoose @gauravagrwal