Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean (ko-KR) translation #29

Open
arthurits opened this issue Mar 18, 2023 · 3 comments
Open

Korean (ko-KR) translation #29

arthurits opened this issue Mar 18, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@arthurits
Copy link
Owner

arthurits commented Mar 18, 2023

This application is currently available in 15 languages, although some extra help is needed (#21) to translate the newly added strings.

  • Arabic (ar). Plain Arabic with no variant.
  • Bangla (bn-BD) Bangla
  • Simplified Chinese (zh-Hans) Chinese
  • Danish (da-DK) Danish
  • English (en) English
  • Belgium Dutch (nl-BE) Dutch
  • German (de-DE) German
  • Hindi (hi-IN) Hindi
  • Italian (it-IT) Italian
  • Lithuanian (lt-LT) Lithuanian
  • Norwegian (Bokmål) (nb-NO) Norwegian (Bokmål)
  • Portuguese (Brazil) (pt-BR) Portuguese (Brazil)
  • Russian (ru-RU) Russian
  • Spanish (es) Spanish
  • Turkish (tr-TR) Turkish

There are a total of 198 strings that need to be translated into Korean (ko-KR). Korea

Instructions

There are several ways to contribute the translation. However, all of them should be done via PR along with one of the following three options:

  • Edit this Excel book and add the translated strings in the table.
  • Add a new file in the project's localization folder named strings.ko-KR.resx. The new file should contain all the string resources from the base strings.resx translated into Korean.
    Some of the string resources include string formatters and other characters (ampersands, line breaks, et cetera) that should be respected in order for the PR to be accepted.
    If you use VS along with the extension ResX Manager you can translate the strings without manually editing the resx file, since the this extension automatically updates the corresponding strings.xx-YY.resx files.
  • Any other option that you are comfortable with.

Please, don't hesitate to ask in case some strings need contextualization for their translation.

@arthurits arthurits added the good first issue Good for newcomers label Mar 18, 2023
@arthurits arthurits added the Hacktoberfest Hacktoberfest 2023 label Sep 20, 2023
@arthurits arthurits removed the Hacktoberfest Hacktoberfest 2023 label Nov 6, 2023
@arthurits arthurits changed the title Korean (ko-KR) translation needed Korean (ko-KR) translation Nov 7, 2023
@youjinup
Copy link

Hi can I do this??

@youjinup
Copy link

Is it okay for me to just translate the English in Excel in No. 1 into Korean??

@arthurits
Copy link
Owner Author

Hi @youjinup!

Sure your translation is welcome. If Excel is your preference, then go ahead and create a PR where you update this Excel book with the strings translated into Korean. Please, take into account that line breaks and special characters should be respected (there are some & charecters that represent the underscore, in English, for the menu and button texts).
I'll then generate the resx file with your translated strings.

If you need context, screenshots to understand the context of the strings or any kind help, please don't hesiste to let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants