Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonLd::setName() #167

Open
klimov-paul opened this issue Aug 13, 2019 · 0 comments
Open

Add JsonLd::setName() #167

klimov-paul opened this issue Aug 13, 2019 · 0 comments

Comments

@klimov-paul
Copy link
Contributor

For the JSON Linked Data page title is represented as 'name' JSON key.
It is expected that JsonLd class have a method named setName(). However, at the present state 'name' key is controller via setTitle() method, which is confusing.
I suppose we can keep JsonLd::setTitle() for the consistency with other SEO classes, however it should be mere an alias for JsonLd::setName()

Q A
This Package Version 0.15.0
Laravel Framework Version 5.8.31
PHP version 7.2
Operating system *
klimov-paul added a commit to klimov-paul/seotools that referenced this issue Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant