-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable oidc-authservice repository CI for power(ppc64le) architecture. #104
Comments
@kimwnasptd, can you provide a hint for how to get started? How/where is CI handled for this project and to whom should we talk to? |
Introduced a new common package which includes commonly used variables, functions and constants across our code. This package also includes the respective unit tests. Also factored out the definition of a Cacheable authenticator. GitHub-PR: #104 Signed-off-by: Athanasios Markou <[email protected]>
Cleaned up direct deps on go-oidc. Established a clear interface for for what we require from go-oidc and isolated that inside the oidc package. This enables us to consolidate our OIDC related operations in a single place as well as reducing irritating collisions between go-oidc and the internal oidc package. GitHub-PR: #104 Signed-off-by: Mike Kelly <[email protected]> Signed-off-by: Athanasios Markou <[email protected]>
Isolated the coreos/go-oidc dependencies within our new sessions package. Under the sessions package we have all the session related functions and variables. GitHub-PR: #104 Signed-off-by: Athanasios Markou <[email protected]>
Add a new authenticators package which includes the implementations of all the authentication methods that oidc-authservice currently supports. Isolate the dependency to the "k8s.io/apiserver/pkg/authentication/authenticator" package, inside the new authenticators package. GitHub-PR: #104 Signed-off-by: Athanasios Markou <[email protected]>
@athamark : are these tags intended for this issue (does not seem to be relevant with issue reference)? |
@pranavpandit1 you are right. These commits were meant to reference GitHub-PR: #105 instead of this issue. I force-pushed a branch with the correct references. Sorry for the confusion. |
@kimwnasptd: I am also interested, any suggestions on where to start with? |
Is this a bug report or feature request?
Enable the OIDC-authservice repository CI for power(ppc64le) architecture. Any inputs on how we can enable CI for power(ppc64le)? As the current Yaml file in the repository does not explain much about architecture-specific configuration, hence not getting a clear idea. Can you help me with the oidc-authservice CI enabling for power(ppc64le) architecture?
What should the feature do:
This will enable CI of OIDC-authservice for power(ppc64le) which builds and push images for both amd64 and ppc64lee.
Additional Information:
I have created one workflow which will just build and push the images for amd64 and ppc64le. Below is the link to the workflow and pushed images.
Link to the workflow:- https://github.com/amitmukati-2604/oidc-authservice/actions/runs/3674045572/jobs/6211797806
Link to pushed images:- https://hub.docker.com/r/amitmukati2604/oidc-authservice/tags
The text was updated successfully, but these errors were encountered: