Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker build failures #447

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

baerrach
Copy link

@baerrach baerrach commented Sep 24, 2020

Short description of what this resolves:

Docker builds fail as per #446

Changes proposed in this pull request:

Remove workaround for rvm/issues/4068 as this issue was fixed in Aug 28, 2017, use proper rvm installer.

Awestruct 0.6.0 has since been released, use that version. Requires upgrading ruby.

Fixes: #

#446

Barrie Treloar added 2 commits September 24, 2020 14:43
remove workaround for rvm/issues/4068 as this issue was fixed in Aug 28, 2017
@baerrach baerrach changed the title fix: use rvm installer fix: docker build failures Sep 24, 2020
@baerrach
Copy link
Author

The --net=host uses host networking, which means that the container lives in the host port space. Generally not what you want.

The problem is the awestruck binds to localhost by default, which isn't tunneled by docker. Instead it should be binding to the local ip assigned, or better yet just all interfaces 0.0.0.0 to save black magic commands to lookup the assigned ip (and the Dockerfile doesn't include net-tools so good luck with that).

awestruct --bind 0.0.0.0 -d

This allows me to connect to localhost:4242 and get results.

@baerrach
Copy link
Author

Puma caught this error: undefined method `[]' for nil:NilClass (NoMethodError)
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/awestruct-0.6.1/lib/awestruct/rack/generate.rb:19:in `call'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/rack-2.2.3/lib/rack/builder.rb:244:in `call'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/configuration.rb:238:in `call'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/server.rb:620:in `handle_request'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/server.rb:377:in `process_client'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/server.rb:231:in `block in run'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/puma-5.0.0/lib/puma/thread_pool.rb:141:in `block in spawn_thread'
/home/dev/arquillian.github.io/.gems/ruby/2.4.0/gems/logging-2.3.0/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'

Why is this so hard?
I'm assuming there is a bug in awestruct, no changes to repo in 5 years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant