Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove doubled code from calc derived props #22

Merged
merged 2 commits into from
Aug 18, 2024
Merged

remove doubled code from calc derived props #22

merged 2 commits into from
Aug 18, 2024

Conversation

arjunsavel
Copy link
Owner

No description provided.

@arjunsavel arjunsavel merged commit 56b63cf into main Aug 18, 2024
3 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.73%. Comparing base (6cbe1b3) to head (db4aa62).
Report is 15 commits behind head on main.

Files Patch % Lines
src/scope/calc_quantities.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   28.43%   28.73%   +0.31%     
==========================================
  Files          11       11              
  Lines         795      797       +2     
==========================================
+ Hits          226      229       +3     
+ Misses        569      568       -1     
Flag Coverage Δ
unittests 28.73% <50.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants