Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Forward ports to testnet v1.0.4+ (after #40) #43

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

huitseeker
Copy link
Member

@huitseeker huitseeker commented Jun 15, 2024

After: #40
Contributes to #38
This ports the following upstream PRs:

Not a lot to mention here, this will just help smart contract issuance.

Note

This PR includes #40, because I expect it to be merged as-is as soon as the LC is ported to it.
There is only a few commits at the end here.

@huitseeker huitseeker changed the title feat: Forward ports to testnet v1.0.4 (after #40) feat: Forward ports to testnet v1.0.4+ (after #40) Jun 15, 2024
@huitseeker huitseeker changed the base branch from dev to plonk June 15, 2024 14:14
@huitseeker huitseeker marked this pull request as ready for review June 15, 2024 14:14
ctian1 and others added 3 commits June 15, 2024 10:17
Co-authored-by: John Guibas <[email protected]>
Co-authored-by: Ratan Kaliani <[email protected]>

fix: should say feature plonk

chore: rename release, set latest release to pre-release

encode proof solidity

encode proof solidity

lint

docs

chore: remove pr workflow activation on push to dev
Copy link
Collaborator

@wwared wwared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much simpler PR than #40

@huitseeker huitseeker merged commit 3312813 into plonk Jun 15, 2024
5 of 6 checks passed
@huitseeker huitseeker deleted the forward_ports_36 branch June 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants