fix: swallowed error in startMissingWatches #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
| } | ||
| return fmt.Errorf("failed to start watch %s: %w", api.GroupKind.String(), err) |
There was a problem hiding this comment.
Shouldn't this be wrapped in an else to avoid throwing an error when the resource is just restricted?
There was a problem hiding this comment.
I dont think it makes sense to call c.watchEvents if resourceVersion is nil and there is an error.
If keep is true, that means the resource is restricted (k8sErrors.IsForbidden(err) || k8sErrors.IsUnauthorized(err)), but the controller has permissions... it sounds like it should never happens.
And there is another codepath here that has a a different logic, so I think both should be the same. @gdsoumya can you give more insights on what should be happening.
gitops-engine/pkg/cache/cluster.go
Lines 870 to 871 in b04ee04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If loadInitialState returns an error, it is possible to still call watchEvents and loadInitialState again when the resource type in error is not restricted.