Fix armv7l install by using `arch' #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See aredridel#57 for details and related threads
|
to test: start a package See if that works? |
aredridel
requested changes
Jan 15, 2019
| var actualCpu = cpu; | ||
|
|
||
| if (cpu === 'arm') { | ||
| const armCpu = execSync('arch') |
There was a problem hiding this comment.
I don't think this is the right place for this though: this is the download script, not installArchSpecific. This always just runs on my laptop.
There was a problem hiding this comment.
You want to modify https://github.com/aredridel/node-bin-setup
|
Closed in favor of aredridel/node-bin-setup#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will fix #57, but I've been having troubles verifying that locally. Is there a test I can run to get
installArchSpecificPackageto run? (It happens onnpm i node@8).See #57 for details and related threads.