Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow working on models based on repositories having the same name #133

Closed
jbsarrodie opened this issue Mar 31, 2020 · 1 comment
Closed

Comments

@jbsarrodie
Copy link
Member

When importing a remote model to the workspace while the target folder already exists, we get this kind of "Folder is not empty" error:
image

I think we should manage this in a more user friendly way.

I can see two strategies:

  1. Keep current behavior but use the FQDN or the repo instead of only the repo name. This would lead to more unique folder name and would solve the root cause.
  2. Change the behavior so that when this error is raised, we ask the user if he/she wants to cancel or continue. If he/she wants to continue, then we add some randow text at the end of the folder name to be created.

The first option seems easier to manage, but the second has the advantage to allow someone to import a model more than once. Of course this should not be done unless you have a very specific need (TBH, the only use-case I see is us trying to simulate several people working on the same model, but for this I usually manually change the folder name anyway).

@jbsarrodie
Copy link
Member Author

Closing as this duplicates #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant