Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some repair messages in the TransactionChain #1587

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Add some repair messages in the TransactionChain #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1498e98
transaction_exists_globally? repair function
bchamagne Oct 29, 2024
fc69235
fetch_genesis_address repair function
bchamagne Oct 29, 2024
6dbb2f5
add commented repair function to implement after 1562
bchamagne Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
252 changes: 239 additions & 13 deletions lib/archethic/transaction_chain.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
TransactionSummaryMessage,
UnspentOutputList,
GetFirstTransactionAddress,
FirstTransactionAddress
FirstTransactionAddress,
ShardRepair
}

alias __MODULE__.MemTables.KOLedger
Expand Down Expand Up @@ -302,13 +303,35 @@
Enum.max_by(results, &DateTime.to_unix(&1.timestamp, :millisecond))
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %GetLastTransactionAddress{address: last_address}, results_by_node ->
# results_by_node
# |> Enum.reduce([], fn
# {_node_public_key, %GetLastTransactionAddress{address: ^last_address}}, acc ->
# acc

# {node_public_key, %GetLastTransactionAddress{address: _}}, acc ->
# [node_public_key | acc]
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: last_address,
# io_addresses: []
# })
# end

case P2P.quorum_read(
nodes,
%GetLastTransactionAddress{address: address, timestamp: timestamp},
conflict_resolver: conflict_resolver,
timeout: timeout,
acceptance_resolver: acceptance_resolver,
consistency_level: consistency_level
# repair_fun: repair_fun
) do
{:ok, %LastTransactionAddress{address: last_address}} ->
{:ok, last_address}
Expand Down Expand Up @@ -340,10 +363,37 @@
Enum.sort_by(results, &length(&1.addresses), :desc) |> List.first()
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %AddressList{addresses: []}, _results_by_nodes ->
# :ok

# %AddressList{addresses: accepted_addresses}, results_by_nodes ->
# last_accepted_address = List.last(accepted_addresses)

# results_by_nodes
# |> Enum.reduce([], fn {node_public_key, %AddressList{addresses: addresses}}, acc ->
# if last_accepted_address == List.last(addresses) do
# acc
# else
# [node_public_key | acc]
# end
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: last_accepted_address,
# io_addresses: []
# })
# end

case P2P.quorum_read(
nodes,
%GetNextAddresses{address: address, limit: limit},
conflict_resolver: conflict_resolver
# repair_fun: repair_fun
) do
{:ok, %AddressList{addresses: addresses}} -> {:ok, addresses}
{:error, :network_issue} = e -> e
Expand Down Expand Up @@ -419,12 +469,40 @@
end)
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %NotFound{}, _results_by_node ->
# :ok

# %Error{}, _results_by_node ->
# :ok

# %Transaction{address: ^address}, results_by_node ->
# results_by_node
# |> Enum.reduce([], fn
# {_node_public_key, %Transaction{address: ^address}}, acc ->
# acc

# {node_public_key, _}, acc ->
# [node_public_key | acc]
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: address,
# io_addresses: []
# })
# end

case P2P.quorum_read(
nodes,
%GetTransaction{address: address},
conflict_resolver: conflict_resolver,
timeout: timeout,
acceptance_resolver: acceptance_resolver
# repair_fun: repair_fun
) do
{:ok, %NotFound{}} ->
{:error, :transaction_not_exists}
Expand Down Expand Up @@ -693,10 +771,35 @@
|> List.first()
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %TransactionInputList{inputs: accepted_versioned_inputs}, results_by_node ->
# accepted_length = length(accepted_versioned_inputs)

# results_by_node
# |> Enum.reduce([], fn {node_public_key, %TransactionInputList{inputs: versioned_inputs}},
# acc ->
# if length(versioned_inputs) < accepted_length do
# [node_public_key | acc]
# else
# acc
# end
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: address,
# io_addresses: Enum.map(versioned_inputs, & &1.input.from) |> Enum.uniq()
# })
# end

case P2P.quorum_read(
nodes,
%GetTransactionInputs{address: address, offset: offset, limit: limit},
conflict_resolver: conflict_resolver
# repair_fun: repair_fun
) do
{:ok, %TransactionInputList{inputs: versioned_inputs, more?: more?, offset: offset}} ->
{versioned_inputs, more?, offset}
Expand Down Expand Up @@ -772,10 +875,33 @@
}
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %UnspentOutputList{unspent_outputs: accepted_utxos}, results_by_node ->
# results_by_node
# |> Enum.reduce([], fn {node_public_key, %UnspentOutputList{unspent_outputs: utxos}},
# acc ->
# if utxos != accepted_utxos do
# [node_public_key | acc]
# else
# acc
# end
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: address,
# io_addresses: Enum.map(accepted_utxos, & &1.unspent_output.from) |> Enum.uniq()
# })
# end

case P2P.quorum_read(
nodes,
%GetUnspentOutputs{address: address, offset: offset, limit: limit},
conflict_resolver: conflict_resolver
# repair_fun: repair_fun
) do
{:ok,
%UnspentOutputList{
Expand Down Expand Up @@ -805,10 +931,32 @@
Enum.max_by(results, & &1.length)
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %TransactionChainLength{length: accepted_len}, results_by_node ->
# results_by_node
# |> Enum.reduce([], fn {node_public_key, %TransactionChainLength{length: len}} ->
# if len == accepted_len do
# acc
# else
# [node_public_key | acc]
# end
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: last_address,
# io_addresses: []
# })
# end

case P2P.quorum_read(
nodes,
%GetTransactionChainLength{address: address},
conflict_resolver: conflict_resolver
# repair_fun: repair_fun
) do
{:ok, %TransactionChainLength{length: length}} ->
{:ok, length}
Expand Down Expand Up @@ -846,12 +994,37 @@
end
end

repair_fun = fn
nil, _results_by_node ->
:ok

%GenesisAddress{address: ^address}, _results_by_node ->
:ok

%GenesisAddress{address: genesis_address}, results_by_node ->
results_by_node
|> Enum.reduce([], fn

Check warning on line 1006 in lib/archethic/transaction_chain.ex

View workflow job for this annotation

GitHub Actions / Build and test 

Function body is nested too deep (max depth is 2, was 3).
{node_public_key, %GenesisAddress{address: ^address}}, acc ->
[node_public_key | acc]

_, acc ->
acc
end)
|> P2P.get_nodes_info()
|> P2P.broadcast_message(%ShardRepair{
genesis_address: genesis_address,
storage_address: address,
io_addresses: []
})
end

case P2P.quorum_read(
nodes,
%GetGenesisAddress{address: address},
conflict_resolver: conflict_resolver,
timeout: timeout,
acceptance_resolver: acceptance_resolver
acceptance_resolver: acceptance_resolver,
repair_fun: repair_fun
) do
{:ok, %GenesisAddress{address: genesis_address}} ->
{:ok, genesis_address}
Expand Down Expand Up @@ -885,25 +1058,53 @@
end

defp do_fetch_first_transaction_address(address, nodes) do
conflict_resolver = fn results ->
case results |> Enum.reject(&match?(%NotFound{}, &1)) do
[] ->
%NotFound{}

results_filtered ->
Enum.min_by(results_filtered, & &1.timestamp, DateTime)
end
end

case get_first_transaction_address(address) do
{:ok, {first_address, _}} ->
{:ok, first_address}

_ ->
conflict_resolver = fn results ->
case results |> Enum.reject(&match?(%NotFound{}, &1)) do

Check warning on line 1067 in lib/archethic/transaction_chain.ex

View workflow job for this annotation

GitHub Actions / Build and test 

Function body is nested too deep (max depth is 2, was 3).
[] ->
%NotFound{}

results_filtered ->
Enum.min_by(results_filtered, & &1.timestamp, DateTime)
end
end

# repair_fun = fn
# nil, _results_by_node ->
# :ok

# %NotFound{}, _results_by_node ->
# :ok

# %FirstTransactionAddress{address: accepted_address}, results_by_node ->
# results_by_node
# |> Enum.reduce([], fn
# {node_public_key, %NotFound{}}, acc ->
# [node_public_key | acc]

# {_node_public_key, %FirstTransactionAddress{address: ^accepted_address}}, acc ->
# acc

# {node_public_key, %FirstTransactionAddress{address: _}}, acc ->
# [node_public_key | acc]
# end)
# |> P2P.get_nodes_info()
# |> P2P.broadcast_message(%ShardRepair{
# genesis_address: genesis_address,
# storage_address: address,
# io_addresses: []
# })
# end

case P2P.quorum_read(
nodes,
%GetFirstTransactionAddress{address: address},
conflict_resolver: conflict_resolver
# repair_fun: repair_fun
) do
{:ok, %NotFound{}} ->
{:error, :does_not_exist}
Expand Down Expand Up @@ -1138,8 +1339,33 @@
end
end

repair_fun = fn
nil, _results_by_node ->
:ok

%NotFound{}, _results_by_node ->
:ok

%TransactionSummaryMessage{
transaction_summary: %TransactionSummary{genesis_address: genesis_address}
},
results_by_node ->
results_by_node
|> Enum.reduce([], fn
{node_public_key, %NotFound{}}, acc -> [node_public_key | acc]
_, acc -> acc
end)
|> P2P.get_nodes_info()
|> P2P.broadcast_message(%ShardRepair{
genesis_address: genesis_address,
storage_address: address,
io_addresses: []
})
end

case P2P.quorum_read(nodes, %GetTransactionSummary{address: address},
conflict_resolver: conflict_resolver
conflict_resolver: conflict_resolver,
repair_fun: repair_fun
) do
{:ok,
%TransactionSummaryMessage{transaction_summary: %TransactionSummary{address: ^address}}} ->
Expand Down
Loading
Loading