Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repair function to the quorum read #1586

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

bchamagne
Copy link
Member

Description

The repair function might be used to send shardrepair messages to nodes when we detect desynchronization.
Use a keyword list instead of 5 optional arguments.

Fixes #1583

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the P2P Involve P2P networking label Oct 28, 2024
test/archethic/p2p_test.exs Outdated Show resolved Hide resolved
lib/archethic/p2p.ex Show resolved Hide resolved
lib/archethic/p2p.ex Outdated Show resolved Hide resolved
lib/archethic/p2p.ex Outdated Show resolved Hide resolved
lib/archethic/p2p.ex Outdated Show resolved Hide resolved
lib/archethic/p2p.ex Outdated Show resolved Hide resolved
@Neylix Neylix merged commit 507c4be into archethic-foundation:develop Oct 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an optional repair function to the quorum
2 participants