Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of not found proof of work #1539

Open
Neylix opened this issue Jul 16, 2024 · 0 comments · May be fixed by #1557
Open

Incorrect handling of not found proof of work #1539

Neylix opened this issue Jul 16, 2024 · 0 comments · May be fixed by #1557
Assignees
Labels
bug Something isn't working mining Involve transaction validation and mining

Comments

@Neylix
Copy link
Member

Neylix commented Jul 16, 2024

Describe the problem you discovered

When an incoming transaction has an invalid origin signature, the coordinator node does not retrieve the proof of work.
The proof of work returns an empty string. Then the validation stamp is serialized replacing the empty string with <<0::32>>.
Then the cross validators compare the proof of work they found (empty string) with the one in the validation stamp (<<0::32>>) which does not match while all nodes did not found the POW.
This result into a wrong consensus not reach error

Describe the solution you'd like

Define a better workflow for invalid proof of work

Epic

No response

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining labels Jul 16, 2024
@bchamagne bchamagne self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants