Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3614): Support dropdown-item actions on ProposalActions, update DataListItem to support standalone usage #294

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Sep 19, 2024

Description

  • Support dropdownItems property on ProposalActions to display custom actions
  • Update DataListItem component to support button/link rendering and standalone usage
  • Update DropdownItem style to correctly render items with icons aligned on the left

🟥 The only breaking change of this PR would be that if some app component is extending a data-list-item property interface (IDataListItemProps, IVoteDataListItemProps, ..), the related props need to be changed from interface to type

Task: APP-3614

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team September 19, 2024 14:48
thekidnamedkd
thekidnamedkd previously approved these changes Sep 20, 2024
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I saw 64 files change and my eyes popped, but I see it's a lot of pattern adjustment and storybook cleanup. Thanks for the implementation! Left a few Q's as always. :)

Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! TAction makes sense. I was thinking about that when doing the ProposalActions about how to make it more general and flexible as actions could be anything down the road.

*/
emptyStateDescription: string;
/**
* Items to be displayed insdie a dropdown for each proposal action (e.g. remove from list, move up, etc..)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Items to be displayed insdie a dropdown for each proposal action (e.g. remove from list, move up, etc..)
* Items to be displayed inside a dropdown for each proposal action (e.g. remove from list, move up, etc..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants