Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(APP-3308): Fix TextAreaRichText component to expose empty string as default value #290

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(APP-3308): Fix TextAreaRichText component to expose empty string as default value #290

merged 1 commit into from
Sep 19, 2024

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Sep 7, 2024 •
edited by jira bot
Loading

Description

  • Expose empty string instead of empty paragraph (<p></p>) as default value on TextAreaRichText component

Task: APP-3308

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team September 16, 2024 08:32
@cgero-eth cgero-eth force-pushed the fix-APP-3308-fix-rich-text-default-value branch from 9f7c3e2 to 1a691c0 Compare September 17, 2024 13:10
thekidnamedkd
thekidnamedkd approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky one! LGTM. Noted about userEvent.type, thanks for the comment explanation.

src/core/test/setup.ts Show resolved Hide resolved
@cgero-eth cgero-eth merged commit fb7671f into main Sep 19, 2024
4 checks passed
@cgero-eth cgero-eth deleted the fix-APP-3308-fix-rich-text-default-value branch September 19, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @thekidnamedkd