Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solidity style guide #118

Open
sohkai opened this issue Mar 20, 2019 · 0 comments
Open

Add solidity style guide #118

sohkai opened this issue Mar 20, 2019 · 0 comments
Assignees
@sohkai
Labels
enhancement New feature or request 💰 funded An issue that has a bounty on the projects app

Comments

@sohkai
Copy link
Contributor

sohkai commented Mar 20, 2019 •
edited by 0xGabi
Loading

This issue was funded with 60 DAI, see more issues on our dao projects app.

A number of recommendations for developers (including ourselves) to write solidity:

  • Conform to the Solidity style guide
  • Put auth and authP modifiers first
  • Use mappings instead of arrays in upgradable apps
  • Add state checks to view functions
  • Internal / external protection scheme: see 1, 2
  • initialized() is first statement in initialize() (treat like super())
@sohkai sohkai added the enhancement New feature or request label Mar 20, 2019
@sohkai sohkai self-assigned this Mar 20, 2019
@sohkai sohkai mentioned this issue Apr 5, 2019
Open
@0xGabi 0xGabi added the 💰 funded An issue that has a bounty on the projects app label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sohkai sohkai

Labels
enhancement New feature or request 💰 funded An issue that has a bounty on the projects app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sohkai @0xGabi