Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Manager: add functionality to forcibly move tokens #419

Closed
lkngtn opened this issue Aug 20, 2018 · 6 comments
Closed

Token Manager: add functionality to forcibly move tokens #419

lkngtn opened this issue Aug 20, 2018 · 6 comments

Comments

@lkngtn
Copy link
Contributor

lkngtn commented Aug 20, 2018

Note: this has been closed to be tracked in the "wishlist for future upgrades".

When tokens are being used to represent authority within an organization it can be useful for those tokens to be set as non-transferrable.

This allows for users to use tokens to represent reputation within the organization or membership in hierarchical groups.

@izqui
Copy link
Contributor

izqui commented Aug 20, 2018

The non-transferable flag is set when the Token Manager is initialized and we don't allow changing it (a token cannot be changed from transferable to non-transferable or vice-versa), this is already supported in the Token Manager smart contract. This means that the kit that deploys the DAO needs to configure the Token Manager for non-transferable tokens, in the future this will also be doable from the App Center.

A feature that we could implement is the ability for the Token Manager to transfer tokens from one holder to another (protected behind the ACL). We don't have this yet, but the same functionality can be achieved by burning and minting tokens in the same transaction (using an EVMScript), though it is less optimal.

The only thing needed is to communicate users whether the Token Manager is in transferable or non-transferable mode.

@sohkai
Copy link
Contributor

sohkai commented Aug 21, 2018

The only thing needed is to communicate users whether the Token Manager is in transferable or non-transferable mode.

I think this is key, and goes well with providing more information in the Token Manager for users.

A feature that we could implement is the ability for the Token Manager to transfer tokens from one holder to another (protected behind the ACL). We don't have this yet, but the same functionality can be achieved by burning and minting tokens in the same transaction (using an EVMScript), though it is less optimal.

On the fence about this; I think a nice UX improvement would be a way for users to click a button on the interface to transfer tokens, but that can be done without adding more to the token manager's contract itself. Or are we talking about forcibly moving user tokens through protected actions?

@izqui
Copy link
Contributor

izqui commented Aug 22, 2018

@sohkai yep, talking about the Token Manager doing an 'unapproved' transferFrom one account to another (which the MiniMe controller can do). This is specially useful for non-transferable tokens that membership in a group, as you can use it to replace members. Again this can be done with in a callscript that performs both burn and mint, but may be clunkier as it would require having both roles.

@sohkai sohkai added this to the Sprint 1.3 milestone Aug 29, 2018
@sohkai sohkai added the design label Aug 29, 2018
@sohkai sohkai removed the design label Aug 30, 2018
@sohkai sohkai assigned sohkai and unassigned jounih Aug 30, 2018
@sohkai sohkai changed the title Token Manager: Allow setting non-transferrable flag on tokens Token Manager: add functionality to forcibly move tokens Aug 30, 2018
@sohkai sohkai assigned sohkai and unassigned sohkai Aug 30, 2018
@sohkai
Copy link
Contributor

sohkai commented Sep 25, 2018

Verdict on this is to initially provide a UI for accumulating actions (see aragon/client#363), rather than building this directly into the Token Manager contract.

@sohkai
Copy link
Contributor

sohkai commented Sep 26, 2018

Similar to #270, due to the reliance on aragon/client#363 this will be removed from the mainnet scope.

@sohkai sohkai removed this from the sprint: 1.3 milestone Sep 26, 2018
@sohkai
Copy link
Contributor

sohkai commented Mar 18, 2020

Closing; we will evaluate this in future contract upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants