Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: APP-2097 - Metamask not disconnecting properly #810

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Apr 11, 2023

Description

  • Fixes the error where sometimes switching to a network with a custom rpc causes Metamask to not disconnect properly.

Note: The issue is an ongoing one. This is a workaround that merely ignores the error as the wallet doesn't actually get disconnected. For more information, take a look at the Github issue

Task: APP-2097

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team April 11, 2023 10:51
@Fabricevladimir Fabricevladimir merged commit 49ed294 into develop Apr 11, 2023
@Fabricevladimir Fabricevladimir deleted the fix/app-2097 branch April 11, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants