Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use --file-patterns flag for all post analyzers #7365

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: use --file-patterns flag for all post analyzers #7365

wants to merge 10 commits into from

Conversation

DmitriyLewen
Copy link
Contributor

Description

Use --file-patterns flag for all post analyzers.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Aug 21, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review August 21, 2024 09:06
knqyf263
knqyf263 reviewed Sep 2, 2024
View reviewed changes
pkg/fanal/analyzer/language/python/packaging/packaging.go Outdated Show resolved Hide resolved
pkg/fanal/analyzer/analyzer.go Outdated
Options AnalysisOptions
FS fs.FS
Options AnalysisOptions
FilePatterns []string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this filed for file patterns? It looks like matched file paths.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated filed name in 5f493ac

@DmitriyLewen DmitriyLewen mentioned this pull request Sep 16, 2024
Merged
7 tasks
@DmitriyLewen DmitriyLewen force-pushed the fix/file-patterns-for-all-post-analyzers branch from 75200be to 2b4f23b Compare September 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(scan): --file-patterns doesn't work for some post-analyzers
2 participants
@DmitriyLewen @knqyf263