Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache trivy-test-images #7598

Closed
knqyf263 opened this issue Sep 26, 2024 · 0 comments · Fixed by #7599
Closed

ci: cache trivy-test-images #7598

knqyf263 opened this issue Sep 26, 2024 · 0 comments · Fixed by #7599
Assignees
Labels
kind/testing Categorizes issue or PR as related to a unit/integration test.
Milestone

Comments

@knqyf263
Copy link
Collaborator

Description

Currently, we pull test images every time we run integration/module/VM tests on GitHub Actions.

img, err := crane.Pull(imgName)

if err = saveLayer(layer, filePath); err != nil {

These images are rarely changed and should be cached on GitHub Actions to mitigate 429 errors.

Downloading spring4shell-jre11...
Downloading spring4shell-jre[8](https://github.com/aquasecurity/trivy/actions/runs/11045901509/job/30685527564#step:5:9)...
Downloading almalinux-8...
Downloading alpine-3[9](https://github.com/aquasecurity/trivy/actions/runs/11045901509/job/30685527564#step:5:10)...
Error: GET https://ghcr.io/v2/aquasecurity/trivy-test-images/blobs/sha256:e7c96db7181be991f19a9fb6975cdbbd73c65f4a2681348e63a141a2192a5f[10](https://github.com/aquasecurity/trivy/actions/runs/11045901509/job/30685527564#step:5:11): TOOMANYREQUESTS: retry-after: 339.865µs, allowed: 44000/minute

cf. https://github.com/aquasecurity/trivy/actions/runs/11045901509/job/30685527564

@knqyf263 knqyf263 added the kind/testing Categorizes issue or PR as related to a unit/integration test. label Sep 26, 2024
@knqyf263 knqyf263 added this to the v0.56.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/testing Categorizes issue or PR as related to a unit/integration test.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants