Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(template): incorrect image name for asff template #6009

Open
DmitriyLewen opened this issue Jan 26, 2024 Discussed in #6003 · 1 comment
Open

bug(template): incorrect image name for asff template #6009

DmitriyLewen opened this issue Jan 26, 2024 Discussed in #6003 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning scan/secret Issues relating to secret scanning scan/vulnerability Issues relating to vulnerability scanning

Comments

@DmitriyLewen
Copy link
Contributor

Description

asff template uses incorrect image name for language packages.
See example in #6003

Also we don't add image name for misconfigurations and secrets.

Discussed in #6003
@DmitriyLewen DmitriyLewen added kind/bug Categorizes issue or PR as related to a bug. scan/vulnerability Issues relating to vulnerability scanning scan/misconfiguration Issues relating to misconfiguration scanning scan/secret Issues relating to secret scanning labels Jan 26, 2024
@DmitriyLewen
Copy link
Contributor Author

We use []Result for *.tpl templates:

trivy/pkg/report/template.go

Line 79 in 5924c02

err := tw.Template.Execute(tw.Output, report.Results)

But only Report struct contains information about image.

I think we can use Report instead of []Result and update all templates from contrib folder.
@knqyf263 wdyt? If you agree with this - i will start working on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning scan/secret Issues relating to secret scanning scan/vulnerability Issues relating to vulnerability scanning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DmitriyLewen