Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d_thresh calculation issue !!! i guess could you please explain reason behind it. ? #16

Open
VijayaKumarKamma opened this issue Jul 8, 2020 · 1 comment

Comments

@VijayaKumarKamma
Copy link

May i know the reason "d_thresh" calculation is not scaled with the birds eye view height and width where points and all re scaled with height and width of birds eye view ?

d_thresh = np.sqrt(
(warped_pt[0][0] - warped_pt[1][0]) ** 2
+ (warped_pt[0][1] - warped_pt[1][1]) ** 2
)

warped_pt_scaled = [int(warped_pt[0] * scale_w), int(warped_pt[1] * scale_h)]

@mistersingh179
Copy link

In plot_lines_between_nodes distance between the points is calculated. This distance is of the original warped points. There is no scaling on the points. This is why no scaling on the d_thresh either.

In general I agree this code could be made more straight forward by refactoring how scaling is applying. I think it is best to apply when building the transformation matrix once and rather than how it is right now where it is applied when building the bird image and when plotting points on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants