Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-compiler-v2] V2 misses drop errors produced by V1 #14627

Open
brmataptos opened this issue Sep 13, 2024 · 1 comment
Open

[Bug][move-compiler-v2] V2 misses drop errors produced by V1 #14627

brmataptos opened this issue Sep 13, 2024 · 1 comment
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

brmataptos commented Sep 13, 2024

🐛 Bug

V1 errors about some missing drop ability in test outputs:

  • third_party/move/move-compiler/tests/move_check/typing/exp_list_resource_drop.exp
  • third_party/move/move-compiler/tests/move_check/typing/ignore_inferred_resource.exp

V2 previously had these tests in directories where the ability check doesn't happen, but even in /ability-check/ (after #14578), this error doesn't appear,

  • third_party/move/move-compiler-v2/tests/ability-check/typing/exp_list_resource_drop.exp
  • third_party/move/move-compiler-v2/tests/ability-check/typing/ignore_inferred_resource.exp
    It's possible this results from limitations of the tests, more study is needed.
@brmataptos brmataptos added the bug Something isn't working label Sep 13, 2024
@wrwg
Copy link
Contributor

wrwg commented Oct 31, 2024

Need to verify because missing drop was recently fixed

@brmataptos brmataptos added the stale-exempt Prevents issues from being automatically marked and closed as stale label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: For Grabs
Development

No branches or pull requests

2 participants