Skip to content

aprescott/sidekiq-symbols

Repository files navigation

sidekiq-symbols

Build Status

sidekiq-symbols gives you symbol keys and Ruby keyword arguments for your Sidekiq jobs.

License

Copyright (c) 2014 Adam Prescott, licensed under the MIT license. See LICENSE.

Caveats

While there is an automated test suite, and I have smoke-tested manually, I have not thoroughly tested this in a production environment! The 0.x version is there for a reason!

Installing

With Bundler:

# in Gemfile
gem "sidekiq-symbols"

Either require "sidekiq-symbols" or require "sidekiq/symbols".

To use

Include the Sidekiq::Symbols module in your job class:

class SomeJob
  include Sidekiq::Worker
  include Sidekiq::Symbols

  # ...
end

What it does

Consider this Sidekiq job:

class SomeJob
  include Sidekiq::Worker

  def perform(opts = {})
    raise unless opts.has_key?(:x)
  end
end

# used as:

SomeJob.perform_async(x: 1)

Because Sidekiq round-trips job arguments through JSON serialization-deserialization, this job will raise as the arguments are converted from

{ x: 1 }

to

{ "x" => 1 }

and then passes it to perform. So it will end up being called as:

perform("x" => 1)

sidekiq-symbols forces perform to work with symbols, not strings:

class SomeJob
  include Sidekiq::Worker
  include Sidekiq::Symbols

  def perform(arg, opts = {})
    opts[:x] == 1 # this is true now!
  end
end

SomeJob.perform_async("foo", x: 1)

Note that this means you cannot use strings for this job! perform_async("foo", "x" => 1) here is converted to perform("foo", x: 1) because Sidekiq::Symbols is included.

Keyword arguments

Ruby's keyword arguments are essentially an extension of using a symbol-keyed hash argument, so sidekiq-symbols also enables keyword arguments:

class SomeJob
  include Sidekiq::Worker
  include Sidekiq::Symbols

  def perform(x: 1, y: 2)
    # x and y are available
  end
end

Beware subclasses!

You may be tempted to add include Sidekiq::Symbols to a base class and inherit from that base class to get symbol support. This will not work how you expect.

Specifically, this situation won't correctly symbolize keys:

# does NOT work

class BaseJob
  include Sidekiq::Worker
  include Sidekiq::Symbols
end

class FooJob < BaseJob
  def perform
    # ...
  end
end

As long as you stick to keeping include Sidekiq::Symbols on "leaf" classes (at the bottom of the inheritance chain), it should work.

# does work

class BaseJob
  include Sidekiq::Worker
end

class FooJob < BaseJob
  include Sidekiq::Symbols

  def perform
    # ...
  end
end

It is recommended that you test any job classes that use Sidekiq::Symbols and that also rely on subclassing.

Development

Issues (bugs, questions, etc.) should be opened with the GitHub project.

To contribute changes:

  1. Visit the GitHub repository for sidekiq-symbols.
  2. Fork the repository.
  3. Make new feature branch: git checkout -b master new-feature (do not add on top of master!)
  4. Implement the feature, along with tests.
  5. Send a pull request.

Tests live in spec/. Run them with rspec. To run tests against various Sidekiq versions, use appraisal rspec. (See the Appraisal project and the Appraisals file for more details.)

About

Symbol keys and Ruby keyword arguments for your Sidekiq jobs

Resources

License

Stars

Watchers

Forks

Packages

No packages published

Languages